Repository navigation
refactor isReportInGroupPolicy to use policy from useOnyx part 1 - #92340
Conversation
Codecov Report❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.
|
|
@DylanDylann Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
PR doesn’t need product input as a refactor PR. Unassigning and unsubscribing myself. |
There was a problem hiding this comment.
@daledah Could we remove this function and use isGroupPolicy function instead?
There was a problem hiding this comment.
@DylanDylann, I've updated the TODO comment to reflect that we'll remove isReportInGroupPolicy entirely and use isGroupPolicy directly. However, removing isReportInGroupPolicy will be done in a separate PR since it's used in multiple places across components and other util functions.
Reviewer Checklist
Screenshots/VideosScreen.Recording.2026-06-09.at.16.01.16.mov |
|
Failed ESLint is unrelated |
|
@lakchote all looks good now. This PR is ready to merge |
|
@lakchote looks like this was merged without a test passing. Please add a note explaining why this was done and remove the |
|
🚧 @lakchote has triggered a test Expensify/App build. You can view the workflow run here. |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
🚀 Deployed to staging by https://github.com/lakchote in version: 9.4.5-0 🚀
Bundle Size Analysis (Sentry): |
|
🤖 Help site review: no documentation changes required. I reviewed the changes in this PR against the help site files under This is a pure internal code refactor with no user-facing impact:
Since the help site documents user-facing product behavior — and this refactor changes none of it — no draft help site PR was created. @daledah, please confirm you agree no help site changes are required here. If you believe a docs update is warranted, let me know what behavior changed and I'll create the draft PR. |
|
🚀 Deployed to production by https://github.com/Julesssss in version: 9.4.5-6 🚀
|
Explanation of Change
Refactor isReportInGroupPolicy to use policy from useOnyx
Fixed Issues
$ #66415
PROPOSAL:
Tests
Offline tests
QA Steps
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
Screen.Recording.2026-06-02.at.16.53.33.mov